Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoD engraving, keybinds #244

Merged
merged 2 commits into from
Jan 20, 2024
Merged

SoD engraving, keybinds #244

merged 2 commits into from
Jan 20, 2024

Conversation

Road-block
Copy link
Contributor

No description provided.

@Rottenbeer
Copy link
Owner

thanks for the PR.
did you test this on wow classic, sod, wotlk(or all the other variants)
my subscription expired, so I can't test it.

@Road-block
Copy link
Contributor Author

SoD and wotlk, no other variants.

@RealityWinner
Copy link

A better fix would be https://github.com/RealityWinner/ItemRack/commit/298bbee67a1794a58eb47d05949e7f65acc34b0d
Alternatively deleting the entire SaveBindings call as it's redundant since they are loaded at login.

@Road-block
Copy link
Contributor Author

Alternatively deleting the entire SaveBindings call as it's redundant since they are loaded at login.

I don't believe that's true for non-static bindings (ie not created through a bindings.xml file)
That's the whole reason the call was put there originally (not my addon / code but that's my guess).

@Rottenbeer Rottenbeer merged commit 8e0ef25 into Rottenbeer:master Jan 20, 2024
1 check passed
@Rottenbeer
Copy link
Owner

Thanks again for the PR, it's released on curseforge as 3.77.
@RealityWinner Can you open a PR, we'll check if @Road-block changes fixes the issue and i'll look at yours if it doesn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants